feat: Short Block Interval Phase One: 1.5 seconds for BEP-520 #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buddh0
force-pushed
the
bep-520-short-block-interval
branch
2 times, most recently
from
f5ae956 to
31c4c06
Compare
NathanBSC
changed the title
buddh0
force-pushed
the
bep-520-short-block-interval
branch
from
31c4c06 to
3e1318e
Compare
buddh0
force-pushed
the
bep-520-short-block-interval
branch
from
3e1318e to
37d0b23
Compare
emailtovamos
reviewed
Mar 6, 2025
| @@ -385,6 +390,7 @@ contract BSCValidatorSet is IBSCValidatorSet, System, IParamSubscriber, IApplica | |||
| function getMiningValidators() external view override returns (address[] memory, bytes[] memory) { | |||
| uint256 _maxNumOfWorkingCandidates = maxNumOfWorkingCandidates; | |||
| uint256 _numOfCabinets = numOfCabinets > 0 ? numOfCabinets : INIT_NUM_OF_CABINETS; | |||
| uint256 _shuffleInterval = 200; | |||
There was a problem hiding this comment.
There is no mention of shuffleInterval in the BEP-520. Is it supposed to be same as epoch or something else?
There was a problem hiding this comment.
just use it to replce EPOCH here,
before the change, EPOCH = 200, so the result is the same as before.
The effect is the same as following:
change name of the constant var EPOCH to shuffleInterval
There was a problem hiding this comment.
the purpose is let the shuffle process not depend on a var called Epoch Length
because, Epoch Length will change from bsc client side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BEP-520: Short Block Interval Phase One: 1.5 seconds
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: