Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 36 #37

Merged
merged 3 commits into from
May 29, 2024
Merged

Fix issue 36 #37

merged 3 commits into from
May 29, 2024

Conversation

bneijt
Copy link
Owner

@bneijt bneijt commented May 29, 2024

Due to urllib3 having multiple version marker sets, poetry-lock-package would mangle the version markers into a string with the value markers.

Current approach is to ignore the markers for packages with multiple versions, because a specific version is already chosen. This might cause an issue if a version is picked that is platform-dependent and another possible version has no platform markers. However, the chance of that happening is slim to none.

Closes issue #36

@bneijt bneijt merged commit e3c02fd into main May 29, 2024
4 checks passed
@bneijt bneijt deleted the issue_36 branch May 29, 2024 17:48
@jeroeness
Copy link

Thanks, this MR fixed our cicd pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants