Add aria-label and grid header on test hover #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekevss
force-pushed
the
hover-test-name
branch
from
13edcb2 to
6de9e13
Compare
|
Hmm, just wondering if this counts as misusing aria-label, since this is not using it for accessibility, but to implement a UX feature. |
|
That was mostly the idea of adding the aria-label for hover was for the accessibility, and hopefully to make the test grid more accessibility friendly. There's a couple other approaches that I can think of off the top of my head:
|
jedel1043
approved these changes
Jun 1, 2024
jedel1043
changed the title
jedel1043
changed the title
jedel1043
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #148. Added the
aria-labelproperty so that it should display the title on hover. Tested on Firefox and Brave 😄