Updates for ZonedDateTime since / until issue #619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
force-pushed
the
zdt-sinceuntil
branch
from
4be0624 to
baf4eff
Compare
Contributor
Author
|
Test failure I think we have an additional bug somewhere. |
Member
|
We may have just run into a known bug ... is this related to tc39/proposal-temporal#3159? Quite possible that it is us though. |
Manishearth
force-pushed
the
zdt-sinceuntil
branch
from
baf4eff to
9144a14
Compare
Manishearth
force-pushed
the
zdt-sinceuntil
branch
from
9144a14 to
8929d9d
Compare
Manishearth
commented
Nov 4, 2025
| let end = self.time_zone.get_iso_datetime_for(other, provider)?; | ||
| // 4. If ns2 - ns1 < 0, let sign be -1; else let sign be 1. | ||
| // 4. If CompareISODate(startDateTime.[[ISODate]], endDateTime.[[ISODate]]) = 0, then | ||
| if start.date == end.date { |
Contributor
Author
There was a problem hiding this comment.
this step was missing from @nekevss' original PR
Might have been added to the spec later
Contributor
Author
|
@nekevss Nope. Turns out your original PR missed a step; probably because it was written based off of a draft spec change that itself got updated a dozen times. |
nekevss
approved these changes
Nov 4, 2025
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 4, 2025
Uplifts boa-dev/temporal#618, boa-dev/temporal#619 to fix the remaining test262 failures. Bug: 401065166 Change-Id: Ie94eb956b4a0327d9e91c7ca43774cc4ecf3bf18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7120501 Commit-Queue: Manish Goregaokar <[email protected]> Reviewed-by: Łukasz Anforowicz <[email protected]> Cr-Commit-Position: refs/heads/main@{#1540332}
jmajnert
pushed a commit
to jmajnert/chromium
that referenced
this pull request
Nov 6, 2025
Uplifts boa-dev/temporal#618, boa-dev/temporal#619 to fix the remaining test262 failures. Bug: 401065166 Change-Id: Ie94eb956b4a0327d9e91c7ca43774cc4ecf3bf18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7120501 Commit-Queue: Manish Goregaokar <[email protected]> Reviewed-by: Łukasz Anforowicz <[email protected]> Cr-Commit-Position: refs/heads/main@{#1540332}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the implementation for the tc39/proposal-temporal#3141 fix up for merge in tc39/proposal-temporal#3147.
Ported from #530
The reverse_wallclock test still fails