Add support for XLSX files generated by Apache POI and Numbers #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Incorrect Detection of certain
xlsxFiles ininfer::get()When using
infer::get(), I encountered an issue where somexlsxfiles were incorrectly detected aszipfiles. This inconsistency seemed to depend on the source of thexlsxfile.Upon reviewing the code for inferring msooxml files, I found that
xlsxfiles generated by Numbers and Apache POI have thexlbbytes in a different position compared to those from other applications. To ensure correct detection, it was necessary to skip over and check the following PK Header as well.This PR adds a check for the 5th PK Header, allowing proper detection of
xlsxfiles from these sources.