Truncate most test files to 4KiB #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All tests still pass, published crate size is about 157KiB. 4KiB is a fairly arbitrary value. Most files are inevitably no longer valid, so they can't be actually parsed. DOC/PPT/XLS weren't touched as they're being parsed to infer their type.
AlyoshaVasilieva
force-pushed
the
truncate
branch
from
312f36d to
f24ff34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As one possible alternative to #57. All tests still pass, published crate size is about 157KiB.
4KiB is a fairly arbitrary value.
Most files are inevitably no longer valid, so they can't actually be parsed. Not sure that's important for this library or not.
DOC/PPT/XLS weren't touched as they're being parsed to infer their type.