-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand CI Matrix #233
Expand CI Matrix #233
Conversation
.github/workflows/ci.yml
Outdated
- { ruby: "2.7", gemfile: "active_support_6", bundler: "1" } | ||
- { ruby: "3.0", gemfile: "active_support_6", bundler: "1" } | ||
- { ruby: "3.1", gemfile: "active_support_6", bundler: "1" } | ||
- { ruby: "3.2", gemfile: "active_support_6", bundler: "1" } | ||
- { ruby: "3.3", gemfile: "active_support_6", bundler: "1" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Active Support 6 relies on libraries (e.g. base64
, bigdecimal
, etc.) that are no longer part of the default gems in Ruby 3.4. Since business_time
does not appear to rely on these libraries, I did not update the gemspec and chose to test Ruby 3.4 only with Active Support 7+. Please let me know if I should go a different route. Thanks!
/versions/3.4.1/lib/ruby/gems/3.4.0/gems/activesupport-6.1.7.10/lib/active_support/xml_mini.rb:5: warning: bigdecimal was loaded from the standard library, but is not part of the default gems starting from Ruby 3.4.0.
You can add bigdecimal to your Gemfile or gemspec to silence this warning.
/Users/beshadtalayeminaei/.rbenv/versions/3.4.1/lib/ruby/3.4.0/bundled_gems.rb:82:in 'Kernel.require': cannot load such file -- bigdecimal (LoadError)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see inline comments.
.github/workflows/ci.yml
Outdated
@@ -6,10 +6,9 @@ jobs: | |||
runs-on: ubuntu-latest | |||
strategy: | |||
matrix: | |||
ruby: [2.7, "3.0", 3.1, 3.2] | |||
ruby: [2.7, "3.0", 3.1, 3.2, 3.3, 3.4] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[SUGGESTION] Let's limit the core matrix to the supported ruby versions and a subset of the older ruby and activesupport version combinations to the include
.
ruby: [2.7, "3.0", 3.1, 3.2, 3.3, 3.4] | |
ruby: ["3.2", "3.3", "3.4"] |
.github/workflows/ci.yml
Outdated
- { ruby: "2.7", gemfile: "active_support_6", bundler: "1" } | ||
- { ruby: "3.0", gemfile: "active_support_6", bundler: "1" } | ||
- { ruby: "3.1", gemfile: "active_support_6", bundler: "1" } | ||
- { ruby: "3.2", gemfile: "active_support_6", bundler: "1" } | ||
- { ruby: "3.3", gemfile: "active_support_6", bundler: "1" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[SUGGESTION]
- { ruby: "2.7", gemfile: "active_support_6", bundler: "1" } | |
- { ruby: "3.0", gemfile: "active_support_6", bundler: "1" } | |
- { ruby: "3.1", gemfile: "active_support_6", bundler: "1" } | |
- { ruby: "3.2", gemfile: "active_support_6", bundler: "1" } | |
- { ruby: "3.3", gemfile: "active_support_6", bundler: "1" } | |
- { ruby: "2.7", gemfile: "active_support_6" } | |
- { ruby: "3.0", gemfile: "active_support_7" } | |
- { ruby: "3.1", gemfile: "active_support_7" } |
- active_support_6 | ||
- active_support_7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[SUGGESTION] Let's also add an active_support_8
here with a new gemfile.
93bf21d
to
6298e81
Compare
.github/workflows/ci.yml
Outdated
- { ruby: "2.7", gemfile: "active_support_6", bundler: "1" } | ||
- { ruby: "2.7", gemfile: "active_support_7", bundler: "1" } | ||
- { ruby: "3.0", gemfile: "active_support_7", bundler: "1" } | ||
- { ruby: "3.1", gemfile: "active_support_7", bundler: "1" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[PLEASE REMOVE] bundler: "1"
from each of these. They can run under the latest (default) version of bundler for each version of ruby.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Thanks
ed5697b
to
e5a136f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
CI is green on my fork btalayeminaei#1