검색 시작 년도 및 마지막 년도 설정 기능 추가#12
Open
ho8278 wants to merge 1 commit into
Open
Conversation
wjddnwls918
reviewed
Jan 19, 2019
| binding.yearFrom.setValue(2019); | ||
| binding.yearTo.setMinValue(1990); | ||
| binding.yearTo.setMaxValue(2019); | ||
| binding.yearTo.setValue(2019); |
There was a problem hiding this comment.
binding.yearFrom.setMinValue(1990);
binding.yearFrom.setMaxValue(2019);
binding.yearFrom.setValue(2019);
binding.yearTo.setMinValue(1990);
binding.yearTo.setMaxValue(2019);
binding.yearTo.setValue(2019);
최소값이 1990이 최대인가요??
나중에 수정이 용이하게 다른 파일에 값들을 지정하는것도 좋을 것같습니다.
KaquiIOS
reviewed
Jan 20, 2019
| import com.example.yeseul.movieapp.utils.BindingUtil; | ||
|
|
||
| public class NumberPickerDialog extends DialogFragment { | ||
| private MainContract.Presenter listener; |
There was a problem hiding this comment.
그냥 Dialog 대신 DialogFragment 를 이용할 때 얻을 수 있는 장점은 무엇인가요 ?
|
'종료년도 >= 시작년도' 옵션이 추가되면 좋을 것 같습니다. |
nusurprise
reviewed
Jan 20, 2019
| android:gravity="center" | ||
| android:layout_height="wrap_content" | ||
| android:layout_weight="0.5" | ||
| android:text="시작년도" /> |
There was a problem hiding this comment.
시작년도 와 종료년도 문자열을 strings.xml 에서 관리해도 좋을 것 같습니다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
개요
구현 방법
NumberPicker 위젯을 포함한 Custom Dialog생성
데이터 바인딩을 이용해 년도 설정
