#기능추가 제작년도 기간 설정#13
Open
chad1994 wants to merge 1 commit into
Open
Conversation
pengin7384
reviewed
Jan 18, 2019
| private final int PAGE_UNIT = 20; // 한번에 가져올 데이터 개수 | ||
| private int currentPage = 0; // 현재 페이지 index | ||
| private boolean isEndOfPage = false; // 페이지 끝 flag | ||
| private int yearFrom = 1896; |
Author
There was a problem hiding this comment.
조사한 결과에 따르면 최초의 상업영화가 1896년도의 ‘열차의 도착’ 이라고 합니다.
pengin7384
reviewed
Jan 18, 2019
| <string name="search_result_empty">에 대한 검색결과가 없습니다.</string> | ||
| <string name="search_yearFrom">제작년도(최소)</string> | ||
| <string name="search_yearTo">제작년도(최대)</string> | ||
| </resources> |
There was a problem hiding this comment.
string이 많아질 것을 대비해서 알파벳 순서로 정렬하는 것은 어떨까요
Author
There was a problem hiding this comment.
조언 감사합니다.
사소한 부분까지 신경 써보도록 하겠습니다 👍🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
개요
작업 사항