API호출 관련 코드 수정. - #15
Open
Zi-Yun wants to merge 4 commits into
Open
Conversation
GODueol
reviewed
Jan 19, 2019
|
|
||
| // 어댑터에 리스트 추가 | ||
| adapterModel.addItems(movieList); | ||
| disposables.add( |
There was a problem hiding this comment.
Single<SearchMovieResponse> searchMovies(@QueryMap Map<String, String> map);
API의 호출부가 Single클래스로 호출되고 있습니다
보통 Single 클레스로 호출하면 한번의 Stream이 흐르고 나면 완료됨을 명시해주는 클래스로
onNext와 onComplete가 같이 이루어 진다고 알고 있는데 명시적인 Dispose를 해주어야 하나요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
개요
작업사항
Disposable이 적절한 시점에 dispose되도록 수정했습니다.Disposable을 1-1 에서 생성한 필드에 add.MainActivity의onDestroy호출 시 dispose.subscribeOn의 스케쥴러를 thread pool을 사용하는Schedulers.io로 변경했습니다.GlideUtil의loadImageCenterCrop수정.DiskCacheStrategy.RESOURCE로 변경했습니다.onScrollStateChanged메소드를 수정했습니다.