아이템 뷰 바인딩 애니메이션 추가#21
Open
sabgilhun wants to merge 2 commits into
Open
Conversation
wjddnwls918
reviewed
Jan 20, 2019
| animationSet.setDuration(700); // 애니메이션 지속 시간 700ms | ||
| animationSet.addAnimation(scaleAnimation); // 스케일 애니메이션 추가 | ||
| animationSet.addAnimation(alphaAnimation); // 페이드 애니메이션 추가 | ||
| view.startAnimation(animationSet); |
There was a problem hiding this comment.
되게 참신하고 좋은거 같습니다. 제 개인적인 느낌인지는 모르겠지만
스크롤할때 눈이 아픈거 같네요
값들의 수정이 필요할거 같아요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
뷰홀더 재사용을 위해 캐시사이즈 변경하는 코드 삭제
캐시 사이즈가 갱신되어 그에따라 뷰홀더를 계속 생성하는 현상을 막기 위해 삭제하였습니다.
BaseRecyclerAdapter에 view 바인딩 시 애니메이션 추가
뷰홀더에 itemview를 바인딩 할때 애니메이션을 추가하여 스크롤 하여 아이템이 변경되면 애니메이션이 동작하도록 하였습니다.