core::string_view

[vinniefalco]

beast should utter core::string_view directly instead of using the alias lifted into its namespace, for clarity in documentation and source code. the exposition in the docs should also be changed.

[ashtum]

@vinniefalco I was waiting for the boost::string_view discussion on the mailing list to settle, hoping we would eventually get boost::string_view as the replacement for core::string_view, but that never happened.

Anyway, the PR is ready to merge. With this change, Boost.Beast would follow the same approach as Boost.URL and use core::string_view in its public interfaces and documentation.

Currently (before merging the PR) both Boost.JSON and Boost.Beast use an aliased string_view type. If we want this to be consistent, Boost.JSON may need to be updated as well.

Note: Existing user code will continue to work because I kept the alias and marked it as deprecated. However, users who build with warnings-as-errors will see this as a breaking change.

[vinniefalco]

LOL that discussion will never settle. It is another permanent scar @pdimov

[pdimov]

Bumping the requirement to C++17 is always an option.

[vinniefalco]

yes that's a good idea