Skip to content

Add emplace_{back,front} to circular_buffer - rebased to latest develop #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
f9z wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Add emplace_{back,front} to circular_buffer - rebased to latest develop #42

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
df790ee
Add emplace_{back,front} to circular_buffer
AI0867 Nov 10, 2017
c7c0d4a
Add emplace_{back,front} to circular_buffer_space_optimized
AI0867 Nov 10, 2017
90ef625
Add tests for emplace_{back,front}
AI0867 Oct 13, 2018
19a1ce4
Revert "Add tests for emplace_{back,front}"
May 13, 2022
e5b44b1
add emplace_test
May 13, 2022
d5819ae
finalise rebase
May 13, 2022
c4c85d7
replace replace() with destroy_item() + construct()
May 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions include/boost/circular_buffer/base.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1460,7 +1460,8 @@ private empty_value<Alloc>
if (full()) {
if (empty())
return;
replace(m_last, value_type(::boost::forward<Args>(args)...));
Copy link
Copy Markdown

@lano1106 lano1106 Jun 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is wrong. This is your bug!

This is where the temporary object gets created.

What do you think value_type(...) is doing?

It creates a temporary object and call the replace() method that is using assignment!

destroy_item(m_last);
boost::allocator_construct(alloc(), boost::to_address(m_last), ::boost::forward<Args>(args)...);
increment(m_last);
m_first = m_last;
} else {
Expand All @@ -1475,7 +1476,8 @@ private empty_value<Alloc>
if (full()) {
if (empty())
return;
replace(m_last, value_type(::boost::forward<V>(value)));
destroy_item(m_last);
boost::allocator_construct(alloc(), boost::to_address(m_last), ::boost::forward<Args>(args)...);
Copy link
Copy Markdown

@lano1106 lano1106 Jun 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has not been compiled with BOOST_NO_CXX11_VARIADIC_TEMPLATES defined because I do not think this would compile.

There is no variadic template parameter Args (args) here

increment(m_last);
m_first = m_last;
} else {
Expand All @@ -1494,7 +1496,8 @@ private empty_value<Alloc>
if (empty())
return;
decrement(m_first);
replace(m_first, value_type(::boost::forward<Args>(args)...));
destroy_item(m_first);
boost::allocator_construct(alloc(), boost::to_address(m_first), ::boost::forward<Args>(args)...);
m_last = m_first;
} else {
decrement(m_first);
Expand All @@ -1515,7 +1518,8 @@ private empty_value<Alloc>
if (empty())
return;
decrement(m_first);
replace(m_first, value_type(::boost::forward<V>(value)));
destroy_item(m_first);
boost::allocator_construct(alloc(), boost::to_address(m_first), ::boost::forward<Args>(args)...);
Copy link
Copy Markdown

@lano1106 lano1106 Jun 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has not been compiled with BOOST_NO_CXX11_VARIADIC_TEMPLATES defined because I do not think this would compile.

There is no variadic template parameter Args (args) here

m_last = m_first;
} else {
decrement(m_first);
Expand Down