-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for semicolon comment delimiter #22
Open
teeks99
wants to merge
10
commits into
boostorg:develop
Choose a base branch
from
teeks99:semicolon_comments
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5fe3b59
Support for semicolon comment delimiter
teeks99 e45db50
Merge remote-tracking branch 'upstream/develop' into semicolon_comments
teeks99 2aaf6de
Merge remote-tracking branch 'upstream/develop' into semicolon_comments
teeks99 39a8819
Using `s.begin()` to match nearby code.
teeks99 3307429
Only trim if it isn't a full-line comment.
teeks99 f9f3515
Missed de-reference
teeks99 c655033
Bad syntax
teeks99 4e4227b
Commented out assignment doesn't increase the count of values.
teeks99 a6d8665
Broken file
teeks99 d3a8962
Merge remote-tracking branch 'upstream/develop' into semicolon_comments
teeks99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,6 @@ | ||
gv1 = 0#asd | ||
; semi test | ||
; semi_value = 9 | ||
empty_value = | ||
plug3 = 7 | ||
b = true | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -257,6 +257,7 @@ void test_config_file(const char* config_file) | |
desc.add_options() | ||
("gv1", new untyped_value) | ||
("gv2", new untyped_value) | ||
("semi_value", new untyped_value) | ||
("empty_value", new untyped_value) | ||
("plug*", new untyped_value) | ||
("m1.v1", new untyped_value) | ||
|
@@ -267,6 +268,8 @@ void test_config_file(const char* config_file) | |
|
||
const char content1[] = | ||
" gv1 = 0#asd\n" | ||
"; semi comment\n" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A also want to see a commented-out line which has an assignment, and a check to ensure the value is not assigned. |
||
"; semi_value = 9\n" | ||
"empty_value = \n" | ||
"plug3 = 7\n" | ||
"b = true\n" | ||
|
@@ -383,6 +386,4 @@ int main(int, char* av[]) | |
test_config_file(av[1]); | ||
test_environment(); | ||
test_unregistered(); | ||
return 0; | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't you just do
continue;
here?