Make comparisons between heterogenous and homogenous quantities possible #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More specifically: comparing quantities of heterogenous and homogenous unit systems fails to build.
|
@swatanabe what's your opinion on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make comparisons between heterogenous and homogenous quantities possible .
And add a test case that fails without this change.
NOTE that the explicit conversion to
quantity<Unit1, Y>is probably not necessary. It definitely isn't necessary if conversion_factor(Unit2(), Unit1()) == 1, and I believe that it is. Unfortunately I haven't been able to verify that through reviewing the code involved in computing the conversion factor.