Skip to content

update to 2014 CODATA recommended values #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

e-kwsm
Copy link

@e-kwsm e-kwsm commented Jul 23, 2018

2006 CODATA recommended values are used.

Significant changes:

  • /// electron-nuclear magneton moment ratio
    BOOST_UNITS_PHYSICAL_CONSTANT(mu_e_over_mu_N,quantity<dimensionless>,-183.28197092*dimensionless(),8.0e-7*dimensionless());

    became 10x bigger (this should have been −1838.281970292)
  • /// triton-electron magnetic moment ratio
    BOOST_UNITS_PHYSICAL_CONSTANT(mu_t_over_mu_e,quantity<dimensionless>,-1.620514423e-3*dimensionless(),2.1e-11*dimensionless());
    /// triton-proton magnetic moment ratio
    BOOST_UNITS_PHYSICAL_CONSTANT(mu_t_over_mu_p,quantity<dimensionless>,1.066639908*dimensionless(),1.0e-8*dimensionless());
    /// triton-neutron magnetic moment ratio
    BOOST_UNITS_PHYSICAL_CONSTANT(mu_t_over_mu_n,quantity<dimensionless>,-1.55718553*dimensionless(),3.7e-7*dimensionless());

    removed (since CODATA 2010); users can obtain by themselves

@e-kwsm e-kwsm mentioned this pull request Jul 28, 2018
@jhunold
Copy link
Contributor

jhunold commented Sep 14, 2018

The update of mu_e_over_mu_Nis necessary. Simply removing the other three constants is not an option. We have to deprecate them first.

@e-kwsm
Copy link
Author

e-kwsm commented Sep 18, 2018

Simply removing the other three constants is not an option. We have to deprecate them first.

I updated the values.

BTW what is the standard way to deprecate a variable in boost? Other libraries use (wrappers of):

  • [[deprecated]] attribute (C++14): Boost.Atomic, Boost.Unordered
  • __attribute__((deprecated)) (GCC and Clang extension): Boost.Atomic, Boost.Unordered
  • __declspec(deprecated) (MSVC extension): Boost.Asio, Boost.Atomic, Boost.Unordered
  • #pragma message: Boost.Accumulators
  • #warning: Boost.Accumulators

@jhunold
Copy link
Contributor

jhunold commented Sep 19, 2018

We cannot use [[deprecated]]right now because this breaks C++03 compatibility. Which I won't do now.
The last two are only useful (and currently used) for deprecation of whole headers. So a macro abstracting the compiler extensions would be nice. Thinking about it.

@e-kwsm
Copy link
Author

e-kwsm commented Jun 6, 2019

2018 CODATA recommended values are released. I will close this when I create a new PR for 2018.

e-kwsm added a commit to e-kwsm/units that referenced this pull request Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants