Detect redriect when getting docs content from db cache #1920
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1918
It turns out we were already doing the thing Sam suggested in the ticket (detecting meta redirects and redirecting server-side), but that code was not being triggered when fetching rendered content from the database - only from S3.
This turned out to be a simple fix of calling the detection code in the database fetching branch of code.
Note that to reproduce the bug locally, I needed to turn on the
ENABLE_DB_CACHE
setting, which is off by default. This was the main reason this bug was difficult to track down.QA testing procedure
ENABLE_DB_CACHE
environment variable to True (or as an easy hack, change the default in settings.py for testing)/libs/url/
On step 3, you should see the incorrect behavior (flicker) on the
master
branch, but the correct behavior (no flicker) on this branch.