Skip to content

BST-14399: add additional includes for complete docker proxy #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025

Conversation

JonathanSerafini
Copy link
Contributor

@JonathanSerafini JonathanSerafini commented Apr 11, 2025

in order to ensure that all docker images use the optional docker registry proxy
additional includes are added which will be conditionally loaded by the ci pipeline file.

ideally, scanner.yaml would have contained all of this logic, however gitlab does not
allows environment variable interpolation on a nested include.

the change should be backwards compatible

@JonathanSerafini JonathanSerafini marked this pull request as ready for review April 11, 2025 13:39
@JonathanSerafini JonathanSerafini requested a review from a team as a code owner April 11, 2025 13:40
victor-nb
victor-nb previously approved these changes Apr 14, 2025
@JonathanSerafini
Copy link
Contributor Author

@victor-nb upgraded docker to v28

@JonathanSerafini JonathanSerafini merged commit 832cc73 into main Apr 24, 2025
4 checks passed
@JonathanSerafini JonathanSerafini deleted the docker-proxy branch April 24, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants