Skip to content

cli: Set tokio thread name #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

cli: Set tokio thread name #1537

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/cli/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ fn run() -> Result<()> {
// tokio::task::spawn_blocking to create a new OS thread explicitly.
let runtime = tokio::runtime::Builder::new_current_thread()
.enable_all()
.thread_name("bootc")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This change sets the name for threads in the blocking pool, which are named tokio-blocking-N by default. Your PR description mentions you are seeing tokio-runtime-w, which is the default name for worker threads in a multi-threaded Tokio runtime.

The runtime here is created with new_current_thread(), which does not have worker threads, only a blocking pool. This change will rename threads from tokio-blocking-N to bootc-N, but it will not affect any threads named tokio-runtime-w.

Could you please double-check the thread name you are seeing? If it is indeed tokio-runtime-w, then those threads are likely being created by a different Tokio runtime, and this change will not affect them.

.build()
.expect("Failed to build tokio runtime");
// And invoke the async_main
Expand Down