Skip to content

Drop podman host exec #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Drop podman host exec #945

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73cfb1e
lib: Drop usage of hacky run_in_host_mount_ns
cgwalters Dec 6, 2024
1e737fb
install: Use skopeo instead of podman
cgwalters Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions lib/src/podman.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,12 @@ pub(crate) struct ImageListEntry {
#[cfg(feature = "install")]
pub(crate) fn imageid_to_digest(imgid: &str) -> Result<String> {
use bootc_utils::CommandRunExt;
let o: Vec<Inspect> = crate::install::run_in_host_mountns("podman")
.args(["inspect", imgid])
// Use skopeo here as that's our current baseline dependency.
let o: Inspect = std::process::Command::new("skopeo")
.arg("inspect")
.arg(format!("containers-storage:{imgid}"))
.run_and_parse_json()?;
let i = o
.into_iter()
.next()
.ok_or_else(|| anyhow::anyhow!("No images returned for inspect"))?;
Ok(i.digest)
Ok(o.digest)
}

/// Return true if there is apparently an active container store at the target path.
Expand Down
Loading