Lazy load entities when requested instead of initializing everything on load #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ies on requested instead of on initialization
…on (as part of iterable? check)
… Alias old methods nontheless
…ies (OrdersHistogram entries)
…enumerable/block behaviour
|
This branch also includes the retry request logic from PR #14 (with tests) |
|
Tests pass 100% both on Ruby 2.7.1 and 3.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just realized I never submitted this PR because whatever reason. This branch is an attempt at reducing memory allocations by instantiating entities when called instead of doing as part of the response parsing process.