Skip to content

Conversation

@arshm06
Copy link

@arshm06 arshm06 commented Aug 3, 2023

Issue #16. I have written the quickstart docs in the same style and modified it to represent the new repository.

Copy link
Member

@ThomasWaldmann ThomasWaldmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, but it looks like the quick start you have written does not really document borg-import - did you ever use borg-import?

A step by step example
----------------------

.. include:: quickstart_example.rst.inc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see that file (neither in the repo nor in your PR) - did you forget to git add it?

Archives and repositories
-------------------------

A *Borg-Import archive* is the result of a single backup (``Borg-Import create``). An archive
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commandline command invoked by the user is borg-import (lowercase).

So I guess the docs should always write the command in lowercase, only exceptions could be when talking about the project in general (not about the command).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, did you just copy that from borg and just replace borg by borg-import?

That reads strange at least if not misleading, so that should be checked and changed at all places.

Also, the goal is not to duplicate the borg docs, they can be referred to by linking, but to document borg-import.

So guess this needs to get done before further review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants