Closed
Conversation
for using changed cmake build directory
There is no `sigval_t` in FreeBSD so I introduced a simple (standard) workaround so the code will be able to be built on FreeBSD.
The problem is that when you set: ``` set(KUMIR2_CXXFLAGS "-fno-exceptions -std=c++0x -fPIC") ``` and later try to add flags with: ``` list(APPEND KUMIR2_CXXFLAGS "-stdlib=libstdc++") ``` it will be expnded into ``` -fno-exceptions -std=c++0x -fPIC;-stdlib=libstdc++ ``` and this line will effectively prevent the command from compiling files because the semicolon will designate the end of the command and the rest of the arguments (file name to compile, for example) will be treated like a new command. Tested with CMake 3.12.2 on FreeBSD 11.2
Clang is unable to find type_traits in FreeBSD 11.2 so this is an explicit inclusion of `/usr/include/c++/v1` in order to enable Kumir2 builds on FreeBSD.
ghost
added
the
ghost
requested a review
from 
Member
|
А какая версия CMake используется во FreeBSD. И какая версия FreeBSD, кстати? |
Author
Там в коммитах написано - FreeBSD 11.2 (самая свежая из стабильных) и CMake 3.12.2 (из стандартных пакетов). |
Author
|
Компилятор - Clang 6.0.0 (идущий в стандартной поставке с системой), хотя желающие могут обновиться до 8.2 (или какой там сейчас свежак). |
Member
|
Сделал rebase поверх текущего master в апстриме, перезалил master, отправил merge request: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.