Skip to content

Conversation

@dynobo
Copy link
Collaborator

@dynobo dynobo commented Jul 17, 2025

I'd like to do a new release.

This also should fix the security alerts from dependabot.

@dynobo dynobo requested review from LGro and sfalkner July 17, 2025 10:54
@dynobo
Copy link
Collaborator Author

dynobo commented Jul 17, 2025

Argh, scipy interface changed:

Run poetry run pylint parameterspace/ tests/
  poetry run pylint parameterspace/ tests/
  shell: sh -e {0}
************* Module tests.priors.test_beta
tests/priors/test_beta.py:51:8: E1101: Module 'scipy.special' has no 'gamma' member (no-member)
tests/priors/test_beta.py:51:23: E1101: Module 'scipy.special' has no 'gamma' member (no-member)
tests/priors/test_beta.py:51:38: E1101: Module 'scipy.special' has no 'gamma' member (no-member)
************* Module tests.priors.test_truncated_normal
tests/priors/test_truncated_normal.py:52:8: E1101: Module 'scipy.special' has no 'erf' member (no-member)
tests/priors/test_truncated_normal.py:52:49: E1101: Module 'scipy.special' has no 'erf' member (no-member)

What do you think, @LGro, shall I add an upper bound for its version? Or just drop the poetry update commit and only bump parameterspace version, until someone has time for a proper fix?

That was an easy fix. They only disallowed usage via base module, direct import fixed it:
6cae413

Mh, no, seems like an linter issue, imports are working as before. I guess this is a false positive introduced with scipy 1.16.0.
As the issue is in tests only, I'd ignore those findings for now: 1b8d1d2

What do you think, @LGro ?

dynobo added 2 commits July 22, 2025 16:42
Signed-off-by: Holger Buech (CR/AIR2.2) <[email protected]>
Signed-off-by: Holger Buech (CR/AIR2.2) <[email protected]>
@dynobo dynobo force-pushed the feature/bump-version-for-new-release branch 2 times, most recently from 6cae413 to f29322e Compare July 22, 2025 15:01
@dynobo dynobo requested a review from LGro July 22, 2025 15:02
@dynobo dynobo force-pushed the feature/bump-version-for-new-release branch 4 times, most recently from 0f24eec to 99c18b7 Compare July 22, 2025 15:24
@dynobo dynobo force-pushed the feature/bump-version-for-new-release branch from 99c18b7 to 1b8d1d2 Compare July 22, 2025 17:00
@LGro
Copy link
Member

LGro commented Jul 23, 2025

As the issue is in tests only, I'd ignore those findings for now: 1b8d1d2

Sounds good to me, thanks for looking into it ☺️

@dynobo dynobo merged commit 92a66f0 into main Jul 23, 2025
7 checks passed
@dynobo dynobo deleted the feature/bump-version-for-new-release branch July 23, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants