Clear the operations-layer alignment residuals - #1054
Merged
Conversation
Close out the residual items the alignment PR disclosed.
Terminology: lesson-format.md speaks of an RPI traversal, the
dated-PROPOSED eval architecture carries a terminology note, a stale
gate-script mention leaves measure_test, and the dormant GOALS.yaml
pillar script is deleted (with its stale preamble-grandfather entry).
The `ao status` human copy is deliberately NOT changed: "loop evidence"
mirrors the loop_evidence machine key, is permitted by the ubiquitous
language's local-control-structure carve-out, and is pinned by a frozen
compatibility baseline.
The eval command-surface smoke counts all heading depths (#{3,5}) and
now passes when executed end to end.
The vacuous retrieval-quality canary and its smoke are retired — every
Go test they named was already deleted — along with the nightly job
whose only step ran that smoke, with the retrieval-comparison contract
marked dormant and the blocking manifest-paths gate remaining the live
retrieval guard.
The consumer-free dream config block is removed along with the four
resolution helpers it exclusively used; unknown keys in existing
configs still parse, covered by a tolerance test.
The remaining knowledge-shaped writers (provenance miner, team-runner,
ralph) write under .agents/scratch/. bin/ralph still resumes legacy
.agents/ralph/ checkpoints so the documented backwards-compat contract
holds without a migration; both paths and the outside-both refusal now
have tests.
The MEMORY.md consumer audit is recorded in the documentation-authority
contract: two live read-only consumers, retained with a named
retirement condition.
Test-Removal-Reason: the dream config subsystem was deleted with its tests (operations-layer residuals)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01F5zgDPAfgMsQCN8H7W2sw4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes out the residual items that #1051 (operations-layer alignment) explicitly disclosed rather than fixed in-scope. Six items:
docs/contracts/lesson-format.mdspeaks of an RPI traversal; the dated-PROPOSEDdocs/architecture/eval-architecture.mdcarries a terminology note instead of being rewritten; a stalecheck-flywheel-compounding.shmention leavesmeasure_test.go; the dormantscripts/check-pillar-coverage.sh(self-skipping, no invoker) is deleted along with its now-stale preamble-grandfather entry.cli-command-surface-smoke.shcounted#{3,4}while the canonical count spans#{3,5}, so the fixture failed when executed (all=76vs the pinned 89). Widening the regex makes it pass end to end and strengthens the check: 13 five-hash eval subcommand headings now enter the help matrix. The pinned counts are unchanged.main), so the canary ran zero tests. Retired honestly: suite + smoke deleted, delisted from the official canary list, the nightly job whose only step ran that smoke removed (with all fivesummary-job references), anddocs/contracts/retrieval-comparison.mdmarked dormant. The blockingalways.retrieval-manifest-pathsgate remains the live retrieval guard (verified registered and green).dream:config block removed, along with the four resolution helpers it exclusively used. Existing configs carryingdream:keys still parse — covered by a new tolerance test exercising the production loader.bin/ralphnow write under.agents/scratch/.bin/ralphstill resumes legacy.agents/ralph/checkpoints, so the documented backwards-compat contract holds with no migration; the suite grows 3 → 5 tests covering both paths and proving a path outside both dirs is still refused.docs/contracts/agents-documentation-authority.yaml: two live read-only consumers found (the corpus-delta eval harness and the root-memory convention), so it is retained with a named retirement condition rather than removed.Deliberately not changed: the
ao status"loop evidence" copy. It mirrors theloop_evidencemachine key, is permitted by the ubiquitous language's local-control-structure carve-out, and is pinned by a frozen compatibility baseline — completing that cosmetic rename would have meant editing a frozen behavioral record.Why
Every item was a disclosed residual from #1051: dead surfaces that still had to be swept, one fixture that never actually passed, and a knowledge-store-shaped writer set that hadn't reached the ADR-0016 tiers. Left alone they decay into exactly the drift the alignment set out to remove — a canary that proves nothing, a fixture nobody runs, a config block with no consumer.
How I tested
cd cli && go build ./... && go vet ./... && go test ./...— clean (64 packages ok)python3 scripts/check-cathedral-cut-conformance.py— PASSbatsproduct-boundary + operating-contract + mine-all-sessions + ralph-budget-contract — 23 tests greenbash scripts/regen-all.sh --check— all projections current;check-test-count-regression.shPASS via theTest-Removal-Reasontrailerbash evals/agentops-core/fixtures/cli-command-surface-smoke.sh— exit 0 at this head, exit 1 atmain(the defect it fixes, demonstrated in both directions)bash scripts/ci-local-release.sh --quick— PASSED; fullci-local-release.sh— PASSED (154s)ao gate check --full— 67/68; the lone failure (go.cli-architecture) reproduces with byte-identical output on unmodifiedmainin this container (shallow-clone git-ancestry artifact) and passed on GitHub CI last roundPASS(validator context9fad04ff984f2162,not_checked: []). An earlier revision of this commit failed its first fresh validation with two HIGH findings — a dangling nightly invoker of the deleted smoke, and the ralph back-compat test regression. Both were fixed, and this validator independently re-verified each prior finding, re-ran the battery at both trees, and adversarially probed the ralph guard across four path classes to confirm it wasn't loosened.Disclosed, pre-existing, and not repaired here (verified present on
maintoo): two frozen compatibility baselines are stale —families/status/case.jsonassertsao status --helpcontains "loop evidence" (cobra rendersLong, not theShortit greps) andfamilies/config/case.jsonasserts adream_report_dirkey that untouched tests already pin as absent at base. Neither has an automated runner in-tree. They deserve a follow-up bead alongside each other rather than an edit smuggled into this diff. The team-runner dry-run harness fails identically at both trees (codexabsent in this container).Checklist
make build && make testpasses (if Go changes)CHANGELOG.md[Unreleased] Removed entry, mirrored indocs/CHANGELOG.md)🤖 Generated with Claude Code
https://claude.ai/code/session_01F5zgDPAfgMsQCN8H7W2sw4
Generated by Claude Code