Skip to content

Add waiter before creating bucket in integ tests #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add waiter before creating bucket in integ tests #148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions tests/integration/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
# distributed on an 'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF
# ANY KIND, either express or implied. See the License for the specific
# language governing permissions and limitations under the License.
import time

import botocore
import botocore.session
from botocore.exceptions import WaiterError
Expand Down Expand Up @@ -61,6 +63,7 @@ def setUpClass(cls):
cls.client.create_bucket(
Bucket=cls.bucket_name,
CreateBucketConfiguration={'LocationConstraint': cls.region})
cls.wait_bucket_exists(cls.bucket_name)

def setUp(self):
self.files = FileCreator()
Expand All @@ -72,6 +75,12 @@ def tearDown(self):
def tearDownClass(cls):
recursive_delete(cls.client, cls.bucket_name)

@classmethod
def wait_bucket_exists(cls, bucket_name, num_success=5, initial_delay=2):
time.sleep(initial_delay)
for _ in range(num_success):
cls.client.get_waiter('bucket_exists').wait(Bucket=bucket_name)

def delete_object(self, key):
self.client.delete_object(
Bucket=self.bucket_name,
Expand Down