Skip to content

Conversation

@tschoonj
Copy link

@tschoonj tschoonj commented Mar 8, 2021

This patches fixes a deadlock whenever TransferManager._shutdown is
called with cancel==True

This patches fixes a deadlock whenever TransferManager._shutdown is
called with cancel==True
@codecov-io
Copy link

codecov-io commented Mar 9, 2021

Codecov Report

Merging #179 (3da31a7) into develop (e862f6b) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #179      +/-   ##
===========================================
- Coverage    97.79%   97.71%   -0.09%     
===========================================
  Files           15       15              
  Lines         2408     2404       -4     
===========================================
- Hits          2355     2349       -6     
- Misses          53       55       +2     
Impacted Files Coverage Δ
s3transfer/futures.py 95.05% <100.00%> (-0.08%) ⬇️
s3transfer/manager.py 97.53% <0.00%> (-0.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e862f6b...3da31a7. Read the comment docs.

@tschoonj
Copy link
Author

@kdaily could you give this one a look? And #144?

Thanks in advance!!

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.71%. Comparing base (e862f6b) to head (3da31a7).
Report is 262 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #179      +/-   ##
===========================================
- Coverage    97.79%   97.71%   -0.09%     
===========================================
  Files           15       15              
  Lines         2408     2404       -4     
===========================================
- Hits          2355     2349       -6     
- Misses          53       55       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants