Skip to content

Fix hang on shutdown with multiple threadpools #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix hang on shutdown with multiple threadpools #266

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion s3transfer/futures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,15 @@ def submit(self, executor, task, tag=None):
task, executor, self.transfer_id
)
)
future = executor.submit(task, tag=tag)
try:
future = executor.submit(task, tag=tag)
except RuntimeError:
# We just tried to submit a task to an executor that was shutdown
# If that task was the CompleteDownloadNOOPTask, then we had
# expected it to call .announce_done(). If that isn't happening,
# then we need to call it ourselves
self.announce_done()
raise
# Add this created future to the list of associated future just
# in case it is needed during cleanups.
self.add_associated_future(future)
Expand Down