Skip to content

package updates: aws-iam-authenticator to 0.6.29 and aws-signing-helper to 1.4.0 #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2025
Merged

package updates: aws-iam-authenticator to 0.6.29 and aws-signing-helper to 1.4.0 #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7a6a1f
packages: update aws-iam-authenticator to 0.6.29
Sparksssj Jan 27, 2025
97ed468
packages: update aws-signing-helper to 1.4.0
Sparksssj Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/aws-iam-authenticator/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ path = "../packages.rs"
releases-url = "https://github.com/kubernetes-sigs/aws-iam-authenticator/releases"

[[package.metadata.build-package.external-files]]
url = "https://github.com/kubernetes-sigs/aws-iam-authenticator/archive/v0.6.28/aws-iam-authenticator-0.6.28.tar.gz"
sha512 = "2e506dd2f0c28e74df8d7da4ceb4dd6407b5f975fb72c2b1ea34ebae6eaba4c447efdf2e37a161198befcb1a77e7bb6352becf3296a033148d5e51934c290704"
url = "https://github.com/kubernetes-sigs/aws-iam-authenticator/archive/v0.6.29/aws-iam-authenticator-0.6.29.tar.gz"
sha512 = "276efbbf44228b7ef6fe45e80c19443b134664d940706f2634e7478c4e8a3d2499bd0cbe70e1b7916af47dbc66ca1b5419f4738ad1f94ef82fe88f3a06f27d65"
bundle-modules = [ "go" ]

[build-dependencies]
Expand Down
4 changes: 2 additions & 2 deletions packages/aws-iam-authenticator/aws-iam-authenticator.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
%global gorepo aws-iam-authenticator
%global goimport %{goproject}/%{gorepo}

%global gover 0.6.28
%global gover 0.6.29
%global rpmver %{gover}

%global _dwz_low_mem_die_limit 0
Expand Down Expand Up @@ -49,7 +49,7 @@ Conflicts: (%{_cross_os}image-feature(no-fips) or %{name}-bin)

%build
%set_cross_go_flags
export GO_MAJOR="1.22"
export GO_MAJOR="1.23"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change strictly required to build? You are overriding the SDK default and it would be better to leave it alone if it's not required.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other words - I'd rather delete this line than change it.

Copy link
Contributor Author

@Sparksssj Sparksssj Feb 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay - I tired to build without changing the GO_MAJOR or delete this line but it won't build. I think the reason is they updated go version in v0.6.29.
https://github.com/kubernetes-sigs/aws-iam-authenticator/releases/tag/v0.6.29#:~:text=3b3bf6f%20chore%3A%20Update%20to%20go%201.23.4

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a similar issue in the past occured, the SDK was on 1.21:
bottlerocket-os/bottlerocket-sdk@acf1d65

And we moved this package to GO MAJOR 1.22:
0ee5cba

Which matches the go version on v0.6.21:
https://github.com/kubernetes-sigs/aws-iam-authenticator/blob/v0.6.21/.go-version

I also confirmed the toolchain error on check-out.
LGTM

go build -ldflags="${GOLDFLAGS}" -o aws-iam-authenticator ./cmd/aws-iam-authenticator
gofips build -ldflags="${GOLDFLAGS}" -o fips/aws-iam-authenticator ./cmd/aws-iam-authenticator

Expand Down
4 changes: 2 additions & 2 deletions packages/aws-signing-helper/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ path = "../packages.rs"
releases-url = "https://github.com/aws/rolesanywhere-credential-helper/releases"

[[package.metadata.build-package.external-files]]
url = "https://github.com/aws/rolesanywhere-credential-helper/archive/v1.2.0/rolesanywhere-credential-helper-v1.2.0.tar.gz"
sha512 = "c2c7fa2fb319aea0036bf334c59cf2a10520da56a45a3e04a99870becfee5099eeb655933b507d2627ebcfde969f1150f0025ace6e06b88bfa801ee847324d30"
url = "https://github.com/aws/rolesanywhere-credential-helper/archive/v1.4.0/rolesanywhere-credential-helper-v1.4.0.tar.gz"
sha512 = "6da4911c89ea24a1356964f5cedc2cdb06c927a930b189efbf5ccaae60e582714b264fb787b2ed9d575ce5e588d1a057d7f311022c459aca7b7afd9f9c2bc801"
bundle-modules = [ "go" ]

[build-dependencies]
Expand Down
2 changes: 1 addition & 1 deletion packages/aws-signing-helper/aws-signing-helper.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
%global gorepo rolesanywhere-credential-helper
%global goimport %{goproject}/%{gorepo}

%global gover 1.2.0
%global gover 1.4.0
%global rpmver %{gover}

%global _dwz_low_mem_die_limit 0
Expand Down