Added default config files for xfsprogs #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
reviewed
Feb 3, 2025
Comment on lines
+59
to
+61
| # Pull in XFSprogs default config files | ||
| Provides: %{_cross_os}kernel(mkfs-confs) = %{version}-%{release} | ||
|
|
There was a problem hiding this comment.
You don't need this.
Suggested change
| # Pull in XFSprogs default config files | |
| Provides: %{_cross_os}kernel(mkfs-confs) = %{version}-%{release} |
Comment on lines
+300
to
+301
| mkdir -p %{buildroot}%{_cross_datadir}/xfs | ||
| install -p -m 0644 %{S:300} %{buildroot}%{_cross_datadir}/xfs/mkfs.xfs.conf |
There was a problem hiding this comment.
Why not just use the corresponding config file that's already in the xfsprogs package?
Suggested change
| mkdir -p %{buildroot}%{_cross_datadir}/xfs | |
| install -p -m 0644 %{S:300} %{buildroot}%{_cross_datadir}/xfs/mkfs.xfs.conf | |
| mkdir -p %{buildroot}%{_cross_datadir}/xfsprogs/mkfs | |
| ln -s lts_5.10.conf default.conf |
There was a problem hiding this comment.
Nice call, thanks! I didn't realize we can use them in that way.
|
Closed this PR since it is pushed to a wrong branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes bottlerocket-os/bottlerocket#4281
Description of changes:
Part of bottlerocket-os/bottlerocket-core-kit#295
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.