Update rust dependencies#4763
Conversation
Signed-off-by: Patrick J.P. Culp <jpculp@amazon.com>
jpculp
force-pushed
the
20260211-deps
branch
from
ca8095d to
e98e81f
Compare
sources/Cargo.toml
Outdated
| snafu = "0.8" | ||
| tokio = { version = "~1.43", default-features = false } | ||
| tokio-tungstenite = { version = "0.20", default-features = false } | ||
| tokio = { version = "~1.47", default-features = false } |
There was a problem hiding this comment.
From a quick grep - I am not actually seeing any tokio reference being used in any of the code. Can it be removed?
This error also seems unused.
There was a problem hiding this comment.
Technically this is true, but by having it specified in the workspace cargo.toml allows us to more easily lock to the LTS as our other dependencies still require it and will just try to bump to the latest on cargo update.
There was a problem hiding this comment.
I take that back. I thought we had other dependencies that still pulled it in, but maybe not.
There was a problem hiding this comment.
Let me split this into two PRs, one for bumping dependencies and another for pruning. I'd like to take a closer look at our packages.
There was a problem hiding this comment.
This got me looking again - I noticed that we have these deps that are not used in BoB at all:
- handlebars
- tokio
- shlex
Not sure if that is something @jpculp you are tracking in the other separate PR.
jpculp
force-pushed
the
20260211-deps
branch
from
e98e81f to
00bafe4
Compare
5 participants
Description of changes:
Bumped cargo dependencies for packages under
/sources.Testing done:
Built and smoke tested Bottlerocket AMI.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.