Add support for the Dynamic Launcher portal #3948
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, thanks for looking at it, and to @TheEvilSkeleton for rebasing! About the unmarked tasks in the original comment, how do you feel about skipping the Desktop Action configure, and not requiring xdp >= 1.20.1? |
|
Closing due to no activity and I see some tasks in the original comment. Tell me if you are still interested since the feature is a good one. |
|
Not sure how we managed to answer to an old PR almost the same time. Anyway, re-opened. |
I was just getting out of an airplane, maybe some time zone shenanigans 😅 |
|
Oh 👀 |
ignapk
force-pushed
the
dynamic-launcher-portal
branch
from
ed44eae to
d3c68d6
Compare
ignapk
force-pushed
the
dynamic-launcher-portal
branch
from
d3c68d6 to
da21f33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds support for the xdg-desktop-portal dynamic launcher portal, that will allow to install desktop files without the need for manually giving permission with a command or Flatseal. Upon clicking the
Add Desktop Entryoption of a wine installed application, the portal will open a dialog where the user can see the app icon, can change the name and confirm or cancel.Screenshots:
What's missing:
- [ ] Support for [Desktop Action Configure] group in the .desktop file, currently the portal requires exactly one group in the .desktop file for security reasonsThis is portal limitation, so if wanted, can be done in a follow up MR after adding support for it upstream- [ ] Requiring xdg-desktop-portal version >= 1.20.1, otherwise doesn't work due to flatpak/xdg-desktop-portal#1674Modern distributions should have that version alreadyFixes #1366
Type of change
How Has This Been Tested?
Unfortunately, I only managed to test installing the desktop file itself, as I get an error when trying to run apps from the desktop files on main as well:
But the created desktop files are otherwise almost identical to the ones from main (bar the configure action) and show up in the app grid just fine \o/