Skip to content

Conversation

@HimDek
Copy link

@HimDek HimDek commented Jun 28, 2025

Description

Having proton-ge and other custom versions in /usr/share/steam/compatibilitytools.d/ makes it available in steam. This patch should also make them usable in bottles without having to redundantly store the same version inside bottles.

  • Checks subfolders in /usr/share/steam/compatibilitytools.d/ and $XDG_DATA_HOME/Steam/compatibilitytools.d/ and add only proton folders to available_runners
  • Overrid get_runner_path() method to handle the additional folders

Fixes #(issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Test with non-bottles provided proton
  • Install proton outside of bottles
    • Install proton-ge or any version of proton at /usr/share/steam/compatibilitytools.d/.
      or
    • Use steam to install official proton at $XDG_DATA_HOME/Steam/compatibilitytools.d/. (Not tested because as far as I know flatpak build will not be able to access data of flatpak steam. However, if installed natively, it should be able to detect proton from native steam)
  • Ensure flatpak override <Application ID of Bottles> --filesystem=host.
  • Proton installed during the first steps should be visible and usable inside bottles.

This also updates the screenshots from
`data/appstream` to `data/screenshots`.
This also removes the `<developer_name>` tag, as it's deprecated.
TheEvilSkeleton and others added 26 commits February 9, 2025 14:44
This is important to have because complex toggles require slightly
different parameters.

Fixes bottlesdevs#3720
libportal: Update libportal to 0.9.1
vte: Update vte to 0.79.90
vulkan-headers: Update Vulkan-Headers.git to 1.4.309.0
vulkan-tools: Update Vulkan-Tools.git to 1.4.309.0
ImageMagick: Update ImageMagick to 7.1.1-45
fast_float: Add fast_float
The GtkListBox::row-activated signal only emits when
a row is activated, not the child widget. This means,
the check button wouldn't trigger the emission of
the signal, thereby not updating the
NewBottleDialog:selected-environment property.

Fixes bottlesdevs#3740
Add paths for system and user steam compatibility tools
Update get_runner_path() to handle system and user steam compatibility tools
Change steam runners path variable names to avoid confusion with "sys-"
runner path for steam- and usr-steam
Update check_runners() to handle steam and usr steam compatibility tools
fix paranthesis
default empty steam runners
@mirkobrombin
Copy link
Member

Hi, can u re-make this PR on top of main, please? Sorry for the trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants