Add support for pre-run and post-run script arguments and argument placeholders #4102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ineProgram Enhance the WineCommand and WineProgram classes to accept pre-run and post-run script arguments. Update the UI to include fields for these arguments in the launch options dialog.
…andling in WineExecutor
…lass handling in yaml utility
…ript arguments in launch options dialog
evertonstz
changed the title
|
Thanks for your MR. Can you fix the conflict here please? |
Done! Tested locally again it is working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for passing arguments to pre-run and post-run scripts in the Bottles application. It introduces new fields for script arguments in both the backend and frontend, updates the command construction logic to handle these arguments securely, and enhances the launch options dialog to allow users to specify them.
When no script is selected, we get the default ui (post-script in the screenshot), once the user select a scritp, we get a new field to optionally add the desired flags (pre-script in the screenshot)
I've also exposed some config information to be used as placeholder to make common information easily available for commands, supported placeholders are:
%PROGRAM_NAME%%PROGRAM_PATH%%PROGRAM_DIR%%BOTTLE_NAME%%BOTTLE_PATH%I'm using it to run ludusavi backups and restores as post and pre hooks :)