Skip to content

Implement RegistryManager #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Implement RegistryManager #2

wants to merge 6 commits into from

Conversation

cyberphantom52
Copy link
Contributor

@cyberphantom52 cyberphantom52 commented Jan 18, 2025 •
edited
Loading

@cyberphantom52
Copy link
Contributor Author

I haven't exposed any of this via RPC yet because I'm not completely happy with the implementation. Creating a MR to facilitate discussion and suggestions.

@mirkobrombin
Copy link
Member

I haven't exposed any of this via RPC yet because I'm not completely happy with the implementation. Creating a MR to facilitate discussion and suggestions.

What are your doubts?

@cyberphantom52
Copy link
Contributor Author

cyberphantom52 commented Jan 20, 2025 •
edited
Loading

I haven't exposed any of this via RPC yet because I'm not completely happy with the implementation. Creating a MR to facilitate discussion and suggestions.

What are your doubts?

The windows-registry crate doesn't have a constructor for Value type nor does it publicly expose types necessary to construct one manually, which has lead to some unnecessary code in the set_value function.

It also led to having a wrapper enum just to separate out each case.

mirkobrombin
mirkobrombin approved these changes Apr 14, 2025
View reviewed changes
Copy link
Member

@mirkobrombin mirkobrombin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mirkobrombin
Copy link
Member

Can I merge?

@cyberphantom52
Copy link
Contributor Author

Can I merge?

Not yet, need to expose this via gRPC

@cyberphantom52
Copy link
Contributor Author

Should be fine to merge after this review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirkobrombin mirkobrombin Awaiting requested review from mirkobrombin

@edfloreshz edfloreshz Awaiting requested review from edfloreshz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyberphantom52 @mirkobrombin @edfloreshz