Skip to content

fix: null fields and first aid expertise field #622

Merged
erinc00 merged 1 commit into
developmentfrom
fix/null-values-and-incorrect-first-aid-expertise-field
May 12, 2026
Merged

fix: null fields and first aid expertise field #622
erinc00 merged 1 commit into
developmentfrom
fix/null-values-and-incorrect-first-aid-expertise-field

Conversation

@AlperKartkaya

Copy link
Copy Markdown
Contributor

Fixes My Help Requests display polish issues on Android.
Resolves #619

Changes

  • Shows No description provided. instead of rendering blank or null descriptions.
  • Sanitizes assigned helper details before display.
  • Maps first-aid expertise/question values to requester-friendly text: Knows first aid.
  • Hides unknown raw volunteer question text from requester-facing helper details.
  • Adds regression coverage for description fallback and helper expertise formatting.

@AlperKartkaya AlperKartkaya changed the title fix: My Help Requests display polish issues on Android fix: null fields and first aid expertise field May 12, 2026

@erinc00 erinc00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This cleans up requester-facing helper details well and fixes the blank/null description issue in the right place. The sanitization and expertise formatting rules make the UI much safer for inconsistent backend values, and the added tests cover the key regressions. Approved and merging.

@erinc00 erinc00 merged commit 68dd79a into development May 12, 2026
2 checks passed
@kckagancan kckagancan deleted the fix/null-values-and-incorrect-first-aid-expertise-field branch May 12, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants