Improve XSS detection for basic reflected XSS patterns #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Key improvements: - Added attribute breakout + tag injection payloads to priority list (e.g., "><img src=x onerror=alert(1)> which is the most common real-world XSS pattern) - Improved check_executable_context() to detect more event handler patterns beyond just 'alert' - now detects onerror, onload, onfocus, etc. with various JS functions - Added ~50 new attribute breakout payloads to generate_waf_bypass() covering img, svg, body, input, details, video, audio, iframe, marquee, object, and embed tags - Better HTML encoding detection to distinguish between safe (encoded) reflections and exploitable (unencoded) reflections This addresses missing detection for basic reflected XSS like: - "><img src=x onerror=alert(1)> - <img src=x onerror="window.location='...'"> https://claude.ai/code/session_01MZUkP14R3DpPRXkze1HZRg
Split SQL error detection into high-confidence and medium-confidence tiers:
HIGH-CONFIDENCE (report immediately):
- Database-specific error patterns (MySQL, PostgreSQL, Oracle, MSSQL, SQLite)
- PDO/ODBC exceptions
- Very specific SQL syntax errors
MEDIUM-CONFIDENCE (require context validation):
- Generic patterns like "sql error", "database error", "query failed"
- These now require BOTH:
1. Error context indicators (exception, stack trace, warning:, etc.)
2. NOT being in false-positive contexts (tutorials, documentation,
code examples, StackOverflow content)
Removed overly broad patterns:
- "syntax error" (could be JavaScript/CSS errors)
- "near \"" (too generic)
- "at line " (too generic)
This prevents XSS payloads from triggering false positive SQLi reports
when the response contains generic error text that isn't actually SQL-related.
https://claude.ai/code/session_01MZUkP14R3DpPRXkze1HZRg
Replaced overly broad SQL error patterns with database-specific ones: REMOVED patterns (too broad, can match non-SQL errors): - "syntax error" (could be JS/CSS/template errors) - "mysql" (could be in documentation/tutorials) - "postgresql" (could be in documentation) - "sqlite" (could be in documentation) - "sql server" (could be in product descriptions) REPLACED with specific patterns: - "mysql_fetch", "mysql_query", "mysqli_" (PHP functions) - "pg_query", "pg_exec" (PostgreSQL functions) - "sqlite3_", "sqlite3::" (SQLite functions/exceptions) - "you have an error in your sql" (MySQL-specific error) - "syntax error at or near" (PostgreSQL-specific) - "incorrect syntax near" (MSSQL-specific) - "sqlstate[" (PDO error format) - "ora-0", "ora-1" (Oracle error codes) Files updated: - src/scanners/sqli_enhanced.rs (collect_evidence function) - src/scanners/websocket.rs (WebSocket SQLi detection) - src/scanners/graphql_security.rs (GraphQL injection detection) - src/scanners/second_order_injection.rs (second-order SQLi) - src/inference/signals.rs (signal analysis patterns) https://claude.ai/code/session_01MZUkP14R3DpPRXkze1HZRg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key improvements:
(e.g., ">
real-world XSS pattern)
patterns beyond just 'alert' - now detects onerror, onload, onfocus,
etc. with various JS functions
covering img, svg, body, input, details, video, audio, iframe,
marquee, object, and embed tags
(encoded) reflections and exploitable (unencoded) reflections
This addresses missing detection for basic reflected XSS like:
https://claude.ai/code/session_01MZUkP14R3DpPRXkze1HZRg