Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/80 tests #137

Merged
merged 20 commits into from
May 24, 2024
Merged

Test/80 tests #137

merged 20 commits into from
May 24, 2024

Conversation

PitButtchereit
Copy link
Collaborator

@PitButtchereit PitButtchereit commented May 17, 2024

You can execute the tests when you are in the TracEX/ folder with python3 tracex_project/manage.py test and more specific tests with python3 tracex_project/manage.py test extraction or python3 tracex_project/manage.py test tracex.

@PitButtchereit PitButtchereit self-assigned this May 17, 2024
@PitButtchereit PitButtchereit linked an issue May 17, 2024 that may be closed by this pull request
2 tasks
@PitButtchereit PitButtchereit marked this pull request as ready for review May 20, 2024 12:48
@PitButtchereit PitButtchereit requested a review from tkv29 May 21, 2024 08:24
@tkv29 tkv29 requested review from FR-SON and soeren227 May 21, 2024 12:32
@tkv29
Copy link
Collaborator

tkv29 commented May 21, 2024

@FR-SON @soeren227 could you please check the tests and test them locally

@PitButtchereit
Copy link
Collaborator Author

Execute the tests while you are in the TracEX/ folder. Otherwise, the fixtures can not be found. Should be good to review now.

Copy link
Collaborator

@soeren227 soeren227 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality and code quality looks very good to me.
I only pointed out some styling inconsistencies and small grammatical errors.
These are all minor though.
Very good job!

@PitButtchereit PitButtchereit merged commit 07c3f25 into main May 24, 2024
2 checks passed
@nils-schmitt nils-schmitt deleted the test/80-tests branch May 27, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests
4 participants