Refactor/96 improve prompts #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PitButtchereit
requested changes
May 21, 2024
tracex_project/extraction/logic/modules/module_patient_journey_preprocessor.py
Show resolved
Hide resolved
tracex_project/extraction/logic/modules/module_patient_journey_preprocessor.py
Show resolved
Hide resolved
tracex_project/extraction/logic/modules/module_patient_journey_preprocessor.py
Show resolved
Hide resolved
|
Maybe I should give a general disclaimer for this PR. After a lot of trial and error the prompts now make a lot more sense to a human that reads them. The concept of the preprocessing module is more clearly reflected in the prompts. However, the overall performance of the the preprocessing did not increase in a measurable level. Other factors, such as the patient journey, still have a major impact on the quality of the results |
|
Should I wait with the review until you implemented Pits requests or should i go straight ahead? |
I implemented the requested changes, aside from those that are still in discussion. |
PitButtchereit
approved these changes
May 22, 2024
nils-schmitt
requested changes
May 22, 2024
tracex_project/extraction/logic/modules/module_activity_labeler.py
Outdated
Show resolved
Hide resolved
nils-schmitt
approved these changes
May 24, 2024
# Conflicts: # tracex_project/db.sqlite3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improved the prompts of the preprocessor and activity labeler. In order to adapt the other prompts to these changes, the prompts of the time extractor module have also been updated.
The following changes were made…
Preprocessing:
Cohorts:
Activity Labeler:
Time Extractor:
In order to review this PR, please pull (make sure the database is also updated in the process) and test if any of the functionality is broken or scrutinize the prompts in the admin view directly. Determining if the changes are improvements by executing the pipeline has proven to be rather difficult.
This closes #96.