Refactor/135-Code check: Database Results #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Variable Names, Organize Code into Functions, Use ES6 Features
…onstants instead of strings and removing magic numbers
thangixd
changed the title
|
Did u also implemented @nils-schmitt comment |
|
@soeren227 could you check the functionality of the evaluation view pls |
yes |
i did and everything works fine for me |
… pj name themself
…nce its more fitting
|
@thangixd when you reload the branch with clean database, are all mirgations applied? If not, please do so and push again |
…most_frequent_timestamp_correctness_count in Timestamp Correctness
should be already migrated |
soeren227
requested changes
May 24, 2024
soeren227
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this pull request introduces a series of refactoring changes aimed at improving the maintainability and readability of the Database Results application. Significant updates have been made to JavaScript functionality, HTML structure, and the django app.
Changes Made:
JavaScript Updates:
Refactored filter_toggle.js to include a CheckboxSelector class, eliminating the need for hardcoded checkbox handling.
Updated metrics_dashboards.js to utilize constants for configuration while removing magic numbers and add helper function for setting tile colors, enhancing code consistency.
HTML Structure:
Reformatted all HTML files to ensure code consistency and readability.
Django views Refactoring:
Improved the get_context_data method in metrics_dashboard by segmenting the data retrieval process into multiple functions, enhancing readability and maintainability.
Similarly refactored get_context_data in EvaluationView to use smaller, purpose-specific functions for data processing.
Added comprehensive docstrings to every module in views.py, improving documentation and code understandability.
Typing in most modules
This PR closes #135.
Please check the changes and provide feedback. Also check the doc strings. I think it's best if @soeren227 and @tkv29 review the functionality and docs. Code review can be done by someone else.