Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/39 refactoring static UI #48

Merged
merged 4 commits into from
Jan 30, 2024
Merged

Conversation

soeren227
Copy link
Collaborator

#39
Add static directory structure supported by django and move general styling from html files to style.css file.
Now supports static files like e.g images being loaded into html files.

@soeren227 soeren227 added the User Story This is a user story label Jan 8, 2024
@thangixd thangixd mentioned this pull request Jan 8, 2024
1 task
Copy link
Collaborator

@PitButtchereit PitButtchereit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Joop

Copy link
Collaborator

@nils-schmitt nils-schmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the IS_TEST should be turned off before merging

@PitButtchereit
Copy link
Collaborator

@thangixd @soeren227 is this still on?

turning off IS_Test to False
Copy link
Collaborator

@thangixd thangixd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u are right. I changed it to false

@thangixd thangixd merged commit a660748 into main Jan 30, 2024
3 checks passed
@FR-SON FR-SON deleted the feature/39-refactoring-static-ui branch April 3, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Story This is a user story
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants