Feature/32 dataframe framework #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nils-schmitt
requested review from
soeren227,
FR-SON,
thangixd and
PitButtchereit
FR-SON
requested changes
Jan 18, 2024
There was a problem hiding this comment.
Looks very good overall. I didn't run it with the changes though, only read through the changes. There are some minor improvements that should be made.
It might be beneficial to document the insights you had that led to the changed prompts, as we will probably work on that topic further in the future.
PitButtchereit
requested changes
Jan 22, 2024
thangixd
approved these changes
Jan 30, 2024
FR-SON
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working implementation of the dataframe framework.
Please note, that output_handling is removed due to handling issues of dataframe / the csv file.