Adding Type Hints, Fixed Test running, Fixed Flake8 #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requirements were not being installed Changing just to 3.12 for now, so it can mirror my system Still getting the testing to work properly Update test.yml Trying to get the github actions to build the wheel Yet again Maybe older version will work? Reverting changes to GH actions now that its working Final test of GH actions
Removing 3.9 from testing Formatting for flake8 got me adding 3.9 back in, as that was not the issue changing the type hints to using the older style of typing union for python 3.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added type hints so that modern IDE's can help you out with inputs and outputs.
Fixed all the relative imports and the test running on github actions.
Fixed a bunch of small flake8 errors.
I recommend that the docstrings in the tokenizer be redone, they do not match typical docstrings.