Tweak Rails 5 code to support LIMIT/OFFSET #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When LIMIT/OFFSET are used in a query,
extract_value
replaces their values withnil
since the values in the query array are of typeActiveModel::Attribute::WithCastValue
notActiveRecord::Relation::QueryAttribute
. I've updated the method to ask if the objects have avalue
method and to always call it if they do instead of querying their types.