Skip to content

Commit

Permalink
Fix: Ubuntu GitHub test action (#643)
Browse files Browse the repository at this point in the history
The `ubuntu-latest` tag was changed to point to Ubuntu 24.04 and has
caused regressions. See
microsoft/playwright#34251 and
electron/electron#42510 for more details.
TL;DR: 
> The solution is to lift the restrictions that Ubuntu 24.04 implements
in the AppImages.
> ```
> sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0
> ```

## Update
The command above fixed the `Process failed to launch` error, but
instead produced a `Timeout 30000ms exceeded` error. For now, setting
tests to run on ubuntu-22.04 as that seems to work at the moment.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **Chores**
- Enhanced the automated testing workflow by updating the operating
system to Ubuntu 22.04, improving the reliability of our testing
process.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Baruch Odem <[email protected]>
  • Loading branch information
whatuserever and baruchiro authored Feb 11, 2025
1 parent 3e7c007 commit dd8eebb
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
matrix:
os:
# - windows-latest
- ubuntu-latest
- ubuntu-22.04 # TODO: Use latest when https://github.com/electron/electron/issues/42510 is fixed
# - macos-latest

runs-on: ${{ matrix.os }}
Expand All @@ -38,7 +38,7 @@ jobs:
# I ran into problems trying to run an electron window in ubuntu due to a missing graphics server.
# That's why this special command for Ubuntu is here
- run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- yarn test:e2e
if: matrix.os == 'ubuntu-latest'
if: startsWith(matrix.os, 'ubuntu')

- run: yarn test:e2e
if: matrix.os != 'ubuntu-latest'
if: ${{ !startsWith(matrix.os, 'ubuntu') }}

0 comments on commit dd8eebb

Please sign in to comment.