This repository was archived by the owner on Mar 15, 2021. It is now read-only.
V1 properties data assemblies and stimulus sets#33
Open
tiagogmarques wants to merge 9 commits intobrain-score:masterfrom
Open
V1 properties data assemblies and stimulus sets#33tiagogmarques wants to merge 9 commits intobrain-score:masterfrom
tiagogmarques wants to merge 9 commits intobrain-score:masterfrom
Conversation
Method to correct images in the movshon stimulus set by adding a cosine aperture main function should be run two times, one for each stimulus set: access='public' and access='target' saves converted image in a new folder given by the target_dir returns the converted StimulusSet with the new image_paths and new stimuli_id (with -aperture added in the end) Can be run in the command line with arparse and passing the access and target_dir parameters
# Conflicts: # mkgu_packaging/movshon/aperture_correct.py
…s benchmark in mkgu_packaging/dicarlo/marques Assembly for preferred orientation benchmark based on DeValois et al 1982a Assembly for multiple orientation and magnitude related benchmarks based on Ringach et al 2002 Stimulus sets to be used for orientation, magnitude, spatial frequency and size tuning benchmarks
mschrimpf
reviewed
Sep 25, 2020
mschrimpf
reviewed
Sep 25, 2020
|
|
||
| stim = Stimulus(size_px=[size_px, size_px], type_name='blank_stim', save_dir=save_dir, stim_id=0) | ||
|
|
||
| stimuli = pd.DataFrame({'image_id': str(0), 'degrees': [degrees]}) |
Member
There was a problem hiding this comment.
I'm confused by the 'degrees' here -- at this point it's just pixels no?
Contributor
Author
There was a problem hiding this comment.
Here it is actually redundant but see below.
Member
There was a problem hiding this comment.
should probably delete 'degrees' from here then, if there's no connection to degrees at this point
mschrimpf
reviewed
Sep 25, 2020
mschrimpf
reviewed
Sep 28, 2020
|
|
||
| stim = Stimulus(size_px=[size_px, size_px], type_name='blank_stim', save_dir=save_dir, stim_id=0) | ||
|
|
||
| stimuli = pd.DataFrame({'image_id': str(0), 'degrees': [degrees]}) |
Member
There was a problem hiding this comment.
should probably delete 'degrees' from here then, if there's no connection to degrees at this point
Added spatial frequency data assemblies
mschrimpf
approved these changes
Oct 11, 2020
Member
|
will wait with merge until the corresponding PR in github.com/brain-score/brainio_collection/ is up |
Added spatial frequency, surround modulatio, and texture assemblies for V1 properties benchmarks
… for all the cells in eccentricities under 5deg and not just the central 1deg (DeValois1982a) - Same as before but for the peak spatial frequency empirical distribution (DeValois1982b) - Added sample variance and family variance to the empirical distributions (FreemanZiemba2013) - Changed grating stimulus generation procedure to allow generation of specific combinations of parameters instead of all possible combinations (this allows dependences of parameters, for example size and spatial frequency)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added code to generate assemblies and stimuli related to V1 properties benchmark in mkgu_packaging/dicarlo/marques
Assembly for preferred orientation benchmark based on DeValois et al 1982a
Assembly for multiple orientation and magnitude related benchmarks based on Ringach et al 2002
Stimulus sets to be used for orientation, magnitude, spatial frequency and size tuning benchmarks