Syncing from upstream OCA/product-attribute (15.0) - #1607
Merged
Conversation
…e range matching Comparing the price directly against the range bounds with `min <= price <= max` is subject to floating point precision errors: a value like 50.00 may be stored as 49.999999998 and fall outside a range starting at 50, wrongly raising "Discount range not found for the given price.". Use tools.float_compare with the currency rounding so both operands are rounded before comparison, avoiding false negatives at the range boundaries.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 15.0 #1607 +/- ##
=======================================
Coverage 86.09% 86.10%
=======================================
Files 300 300
Lines 4776 4777 +1
Branches 584 584
=======================================
+ Hits 4112 4113 +1
Misses 519 519
Partials 145 145 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bt_gitbot