Syncing from upstream OCA/product-attribute (18.0) - #1613
Merged
Conversation
The price column recomputed the pricelist price one product at a time (``_get_product_price`` per report row), which made the native ``_get_applicable_rules`` rule search run once per product. On large pricelists this dominated the report render time. Precompute every price in a single batched ``_get_products_price`` call and inject the result in the context as ``product_prices`` so ``_compute_product_price`` reads it instead of recomputing. This collapses the per-product rule searches of the printed pricelist into a single one, both for the PDF report and the xlsx export, without changing the price values nor the public method signatures.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 18.0 #1613 +/- ##
==========================================
- Coverage 92.89% 92.86% -0.04%
==========================================
Files 575 575
Lines 9042 9051 +9
Branches 754 756 +2
==========================================
+ Hits 8400 8405 +5
- Misses 451 453 +2
- Partials 191 193 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bt_gitbot