Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin vtk #402

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Unpin vtk #402

merged 2 commits into from
Jan 13, 2025

Conversation

IgorTatarnikov
Copy link
Member

@IgorTatarnikov IgorTatarnikov commented Jan 13, 2025 •
edited
Loading

closes #399

@codecov Codecov
Copy link

codecov bot commented Jan 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.62%. Comparing base (c396136) to head (db10c8d).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #402   +/-   ##
=======================================
  Coverage   86.62%   86.62%           
=======================================
  Files          27       27           
  Lines        1241     1241           
=======================================
  Hits         1075     1075           
  Misses        166      166

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IgorTatarnikov IgorTatarnikov marked this pull request as ready for review January 13, 2025 10:50
@IgorTatarnikov IgorTatarnikov requested a review from a team January 13, 2025 10:51
alessandrofelder
alessandrofelder approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@alessandrofelder alessandrofelder merged commit e7d9be6 into main Jan 13, 2025
13 checks passed
@alessandrofelder alessandrofelder deleted the unpin-vtk branch January 13, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessandrofelder alessandrofelder alessandrofelder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unpin VTK
2 participants
@IgorTatarnikov @alessandrofelder