Fixed updating relationships, when no attributes are specified. #27
Open
jasdefer wants to merge 1 commit intobrainwipe:masterfrom
jasdefer:master
Open
Fixed updating relationships, when no attributes are specified. #27jasdefer wants to merge 1 commit intobrainwipe:masterfrom jasdefer:master
jasdefer wants to merge 1 commit intobrainwipe:masterfrom
jasdefer:master
Conversation
Author
|
I am very unfamiliar with the flow on GitHub and this is my first pull request ever. Don't hesitate and point out my mistakes. |
Owner
|
Hi there, thank you for your pull request. Please can you add Unit Tests for your change. |
Author
|
Okay, I just looked at some tests and the This request should be able to update the relationship of a post |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A patch request modifying the relationship threw an error, because the attributes could not be initialized. An additional null check can solve this problem.